From 13919e260a221ade4fad095d43b51f2bf0ad7043 Mon Sep 17 00:00:00 2001
From: Mark Skipper <marks@aptivate.org>
Date: Sat, 11 Jul 2015 00:01:57 +0100
Subject: [PATCH] Refactor parsing returned items
I think this should really use ItemSerializer
---
django/website/transport/items.py | 20 +++++++++++---------
1 file changed, 11 insertions(+), 9 deletions(-)
diff --git a/django/website/transport/items.py b/django/website/transport/items.py
index 57f34c2e..c4daf8ac 100644
--- a/django/website/transport/items.py
+++ b/django/website/transport/items.py
@@ -24,6 +24,16 @@ def get_view():
return ItemViewSet.as_view(actions)
+def _parse_date_fields(item):
+ date_fields = ('created', 'timestamp')
+ item_dict = dict(item)
+ for date_field in date_fields:
+ value = item_dict[date_field]
+ if value is not None:
+ item_dict[date_field] = parse_datetime(value)
+ return item_dict
+
+
def list(**kwargs):
""" Return a list of Items
@@ -36,16 +46,8 @@ def list(**kwargs):
items = view(request).data
- date_fields = ('created', 'timestamp')
-
for item in items:
- item_dict = dict(item)
- for date_field in date_fields:
- value = item_dict[date_field]
- if value is not None:
- item_dict[date_field] = parse_datetime(value)
-
- item.update(item_dict)
+ item.update(_parse_date_fields(item))
return items
--
GitLab