Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
I
internewshid
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Container Registry
Model registry
Operate
Environments
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
aptivate
client-projects
internewshid
Commits
16a18c01
Commit
16a18c01
authored
5 years ago
by
Daniel Levy
Browse files
Options
Downloads
Patches
Plain Diff
Fix 500 error when adding age ranges
parent
7f6be7c5
No related branches found
Branches containing commit
No related tags found
2 merge requests
!166
Staging
,
!159
Fix 500 error when adding age ranges
Pipeline
#10442
passed
5 years ago
Stage: test
Changes
2
Pipelines
1
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
internewshid/hid/tests/views_tests.py
+14
-0
14 additions, 0 deletions
internewshid/hid/tests/views_tests.py
internewshid/hid/views/item.py
+1
-1
1 addition, 1 deletion
internewshid/hid/views/item.py
with
15 additions
and
1 deletion
internewshid/hid/tests/views_tests.py
+
14
−
0
View file @
16a18c01
...
...
@@ -13,6 +13,7 @@ from hid.tabs.view_and_edit_table import (
_get_view_and_edit_form_request_parameters
,
view_and_edit_table_form_process_items
)
from
hid.views.item
import
AddEditItemView
from
tabbed_page.tests.factories
import
TabbedPageFactory
,
TabInstanceFactory
from
taxonomies.models
import
Taxonomy
,
Term
from
taxonomies.tests.factories
import
TaxonomyFactory
,
TermFactory
...
...
@@ -844,3 +845,16 @@ def test_items_paginated():
assert
items
[
0
][
'
body
'
]
==
'
item 3
'
assert
items
[
1
][
'
body
'
]
==
'
item 4
'
assert
items
[
2
][
'
body
'
]
==
'
item 5
'
def
test_getting_initial_age_ranges_handled_correctly
():
view
=
AddEditItemView
()
request
=
MagicMock
(
session
=
{
'
THREADED_FILTERS
'
:
{}},
GET
=
QueryDict
(
'
next=/
'
)
)
view
.
item_terms
=
{
'
age-ranges
'
:
[{
'
name
'
:
'
<11
'
}]}
view
.
item
=
MagicMock
()
view
.
request
=
request
# If this test fails, there will be an error
view
.
get_initial
()
This diff is collapsed.
Click to expand it.
internewshid/hid/views/item.py
+
1
−
1
View file @
16a18c01
...
...
@@ -186,7 +186,7 @@ class AddEditItemView(FormView):
initial
[
'
feedback_type
'
]
=
self
.
item_terms
[
'
item-types
'
][
0
][
'
name
'
]
if
'
age-ranges
'
in
self
.
item_terms
:
initial
[
'
age_range
'
]
=
self
.
item_terms
[
'
item-typ
es
'
][
0
][
'
name
'
]
initial
[
'
age_range
'
]
=
self
.
item_terms
[
'
age-rang
es
'
][
0
][
'
name
'
]
return
initial
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment