Skip to content
Snippets Groups Projects
Commit 1cce883b authored by Martin Burchell's avatar Martin Burchell
Browse files

Made category field not required on item edit form

parent dcc35581
No related branches found
No related tags found
1 merge request!37Items can be edited when form is submitted
......@@ -30,7 +30,7 @@ class AddEditItemForm(forms.Form):
choices = (('', '-----'),)
choices += tuple((t['name'], t['name']) for t in terms)
self.fields['category'] = forms.ChoiceField(
choices=choices
choices=choices, required=False
)
# The template already has support for optional fields:
# 'region' (select)
......
......@@ -49,3 +49,15 @@ def test_form_category_has_expected_choices():
form = AddEditItemForm('some-item-type')
assert 'category' in form.fields
assert form.fields['category'].choices == expected_choices
def test_category_field_is_not_required():
item_type_category = {
'some-item-type': 'some-taxonomy'
}
with patch.dict('hid.forms.item.ITEM_TYPE_CATEGORY', item_type_category):
with patch('hid.forms.item.transport.terms.list') as term_list:
term_list.return_value = []
form = AddEditItemForm('some-item-type')
assert not form.fields['category'].required
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment