Ansible lint updates

.ansible-lint

+---
+# https://docs.ansible.com/ansible-lint/rules/default_rules.html
+skip_list:
+  # Lines should be no longer than 160 chars
+  - "204"
+  # rsync used in place of synchronize module
+  - "303"
+  # Package installs should not use latest
+  - "403"
+# vim: syntax=yaml
+...

.gitlab-ci.yml

 ---
 image: registry.git.coop/webarch/containers/images/ansible:0.3
-
+before_script:
+  - chmod 700 $(pwd)
 stages:
-  - check
-
-ansible-lint:
-  stage: check
+  - lint
+lint:
+  stage: lint
   script:
     - yamllint .
+    - molecule lint
+# vim: syntax=yaml
 ...

.yamllint

+---
 extends: default
-
+yaml-files:
+  - '*.yaml'
+  - '*.yml'
 rules:
   braces:
     max-spaces-inside: 1
@@ -8,3 +11,6 @@ rules:
     max-spaces-inside: 1
     level: error
   line-length: disable
+  comments-indentation: disable
+# vim: syntax=yaml
+...

molecule/default/molecule.yml

+---
+dependency:
+  name: galaxy
+driver:
+  name: docker
+platforms:
+  - name: instance
+    image: registry.git.coop/webarch/containers/images/ansible:0.3
+    pre_build_image: true
+provisioner:
+  name: ansible
+lint: |
+ set -e
+  yamllint -c .yamllint .
+  ansible-lint -c .ansible-lint.yml .
+# vim: syntax=yaml
+...

tasks/config.yml

@@ -59,7 +59,7 @@
             common_name: "{{ inventory_hostname }}"
 
       when:
-        - ( apache_cert.stat.exists == False )
+        - ( not apache_cert.stat.exists )
         - ( "ssl" in apache_mods_enabled )
         - ( "le" in apache_conf_enabled )
         - ( common_name is defined ) and ( common_name == inventory_hostname )

tasks/main.yml

@@ -46,7 +46,7 @@
 
     - name: Include MPM switching tasks
       include_tasks: mpm.yml
-      when: ( apache_mpm_loaded not in apache_mods_enabled ) or ( apache_mpm_loaded == "" )
+      when: ( apache_mpm_loaded not in apache_mods_enabled ) or ( apache_mpm_loaded | length == 0 )
 
     - name: Apache config available
       include_tasks: config.yml

tasks/mc3.yml

@@ -6,6 +6,7 @@
       git:
         repo: https://git.coop/mc3coop/ssh-templates.git
         dest: /var/www/mc3
+        version: master
         clone: true
         update: true
         force: true

tasks/mpm.yml

@@ -44,7 +44,7 @@
       when: apache_mpm_event_enabled.changed
 
   when:
-    - ( apache_mpm_loaded == "mpm_prefork" ) or ( apache_mpm_loaded | length <= 0 )
+    - ( apache_mpm_loaded == "mpm_prefork" ) or ( apache_mpm_loaded | length == 0 )
     - ( apache_mods_enabled is defined ) and ( "mpm_event" in apache_mods_enabled )
   tags:
     - apache
@@ -73,7 +73,7 @@
       when: apache_mpm_prefork_enabled.changed
 
   when:
-    - ( apache_mpm_loaded == "mpm_event" ) or ( apache_mpm_loaded == "" )
+    - ( apache_mpm_loaded == "mpm_event" ) or ( apache_mpm_loaded | length == 0 )
     - ( "mpm_prefork" in apache_mods_enabled )
   tags:
     - apache

tasks/webarch.yml

@@ -6,6 +6,7 @@
       git:
         repo: https://git.coop/webarch/website-templates.git
         dest: /var/www/wsh
+        version: master
         clone: true
         update: true
         force: true