additional checks for running in check mode added

.pre-commit-config.yaml

@@ -17,19 +17,19 @@ repos:
         name: YAML Lint
   # https://github.com/ansible/ansible-lint/releases
   - repo: https://github.com/ansible/ansible-lint.git
-    rev: v6.20.3
+    rev: v6.21.1
     hooks:
       - id: ansible-lint
         name: Ansible Lint
         language: python
         additional_dependencies:
           # https://github.com/kellyjonbrazil/jc/releases
-          - jc==1.23.4
+          - jc==1.23.6
           # https://github.com/jmespath/jmespath.py/tags
           - jmespath==1.0.1
   # https://github.com/jackdewinter/pymarkdown/releases
   - repo: https://github.com/jackdewinter/pymarkdown.git
-    rev: v0.9.13.4
+    rev: v0.9.14
     hooks:
       - id: pymarkdown
         name: Markdown Lint

README.md

@@ -36,6 +36,12 @@ mariadb_config:
         default_character_set: utf8mb4
 ```
 
+You can get the existing configuration as YAML using:
+
+```bash
+cat /etc/mysql/mariadb.conf.d/50-server.cnf | jc --ini -p | yq -o=yaml -P
+```
+
 ### mariadb_mysqltuner
 
 A boolean, `mariadb_mysqltuner` defaults to `true` and results in [MySQLTuner](https://github.com/major/MySQLTuner-perl) being installed using a Debian package or from GitHub depending on the version specified using `mariadb_mysqltuner_version`.

tasks/mysqltuner.yml

@@ -147,6 +147,11 @@
                 depth: 1
                 update: true
 
+            - name: Check that MySQLTuner code is present
+              ansible.builtin.stat:
+                path: /usr/local/src/MySQLTuner-perl/mysqltuner.pl
+              register: mariadb_mysqltuner_script
+
             - name: MySQLTuner script in place
               ansible.builtin.copy:
                 src: /usr/local/src/MySQLTuner-perl/mysqltuner.pl
@@ -155,6 +160,7 @@
                 mode: "0755"
                 owner: root
                 group: root
+              when: mariadb_mysqltuner_script.stat.exists | bool
 
             - name: Directory for MySQLTuner assets in place
               ansible.builtin.file:
@@ -164,6 +170,11 @@
                 owner: root
                 group: root
 
+            - name: Check that MySQLTuner passwords is present
+              ansible.builtin.stat:
+                path: /usr/local/src/MySQLTuner-perl/basic_passwords.txt
+              register: mariadb_mysqltuner_passwords
+
             - name: MySQLTuner basic_passwords.txt file in place
               ansible.builtin.copy:
                 src: /usr/local/src/MySQLTuner-perl/basic_passwords.txt
@@ -172,6 +183,12 @@
                 mode: "0644"
                 owner: root
                 group: root
+              when: mariadb_mysqltuner_passwords.stat.exists | bool
+
+            - name: Check that MySQLTuner vulnerabilities is present
+              ansible.builtin.stat:
+                path: /usr/local/src/MySQLTuner-perl/vulnerabilities.csv
+              register: mariadb_mysqltuner_vulnerabilities
 
             - name: MySQLTuner vulnerabilities.csv file in place
               ansible.builtin.copy:
@@ -181,6 +198,7 @@
                 mode: "0644"
                 owner: root
                 group: root
+              when: mariadb_mysqltuner_vulnerabilities.stat.exists | bool
 
           when: >-
             ( ansible_local.dpkg.installed is not defined ) or